movies-list-add-form #2085
Open
movies-list-add-form #2085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etojeDenys
suggested changes
Jan 12, 2024
src/components/NewMovie/NewMovie.tsx
Outdated
Comment on lines
7
to
11
| const [title, setTitle] = useState(''); | ||
| const [description, setDescription] = useState(''); | ||
| const [imgUrl, setImgUrl] = useState(''); | ||
| const [imdbUrl, setImdbUrl] = useState(''); | ||
| const [imdbId, setImdbId] = useState(''); |
There was a problem hiding this comment.
we can combine it in one useState
const [newMovie, setNewMovie] = useState({
title: '',
...
})
now we can also create only one handle function for all fields
const handleChange = (e: ...) => {
const {name, value} = e.target;
setMovie((prevMovie) => ({...prevMovie, [name]: value}))
}
don't forget to specify name attr to input in TextField
nazarmatsevych
suggested changes
Jan 15, 2024
maxim2310
suggested changes
Jan 15, 2024
There was a problem hiding this comment.
Good work, but lets make some improvement
form works strange, errors appear in different places and dont added new film after submit
https://www.loom.com/share/ef26224b8df14f3a8dcbd0ec67dbb511
Viktor-Kost
approved these changes
Jan 22, 2024
Comment on lines
+9
to
+19
|
|
||
| export const NewMovie: React.FC<Props> = ({ onAdd }) => { | ||
| const [count, setCount] = useState(0); | ||
|
|
||
| const [newMovie, setNewMovie] = useState({ | ||
| title: '', | ||
| description: '', | ||
| imgUrl: '', | ||
| imdbUrl: '', | ||
| imdbId: '', | ||
| }); |
There was a problem hiding this comment.
move an initial state to a variable
Suggested change
| export const NewMovie: React.FC<Props> = ({ onAdd }) => { | |
| const [count, setCount] = useState(0); | |
| const [newMovie, setNewMovie] = useState({ | |
| title: '', | |
| description: '', | |
| imgUrl: '', | |
| imdbUrl: '', | |
| imdbId: '', | |
| }); | |
| const initialMovieState = { | |
| title: '', | |
| description: '', | |
| imgUrl: '', | |
| imdbUrl: '', | |
| imdbId: '', | |
| } | |
| export const NewMovie: React.FC<Props> = ({ onAdd }) => { | |
| const [count, setCount] = useState(0); | |
| const [newMovie, setNewMovie] = useState(initialMovieState); |
Comment on lines
+60
to
+66
| setNewMovie({ | ||
| title: '', | ||
| description: '', | ||
| imgUrl: '', | ||
| imdbUrl: '', | ||
| imdbId: '', | ||
| }); |
There was a problem hiding this comment.
Suggested change
| setNewMovie({ | |
| title: '', | |
| description: '', | |
| imgUrl: '', | |
| imdbUrl: '', | |
| imdbId: '', | |
| }); | |
| setNewMovie(initialMovieState); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK